Skip to content

Updated webhook update method to not send id in request #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2016
Merged

Updated webhook update method to not send id in request #165

merged 1 commit into from
Aug 26, 2016

Conversation

aydrian
Copy link
Contributor

@aydrian aydrian commented Aug 26, 2016

Removed id from the webhook object before passing it on to the request. Added a check to make sure id was included and a test.

Added some code cleanup.

Fixes #164

@coveralls
Copy link

coveralls commented Aug 26, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c48eb84 on aydrian:issue-164 into ff39f79 on SparkPost:master.

@colestrode
Copy link
Contributor

looks good, I was able to confirm the issue and the fix. :shipit:

@aydrian aydrian merged commit 57684c8 into SparkPost:master Aug 26, 2016
@aydrian aydrian deleted the issue-164 branch August 26, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aydrian @coveralls @colestrode