Modal concurrency enhance #228
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `modal_webui.py` script is what I use to deploy the SparkTTS Gradio web UI on Modal. With this change, I've added the `@modal.concurrent(max_inputs=10)` decorator to the main `run` function. This is in line with Modal's best practices and examples for deploying web server applications (like Gradio, Streamlit, ComfyUI) that are started via `subprocess.Popen`. Adding this decorator allows the Modal container to accept multiple simultaneous client connections from you (up to 10 in this case), which should improve responsiveness if multiple users are interacting with it. The actual processing of these requests by the SparkTTS model will still depend on the underlying Gradio server and GPU capacity. I reviewed the script and found it to be otherwise correctly implementing Modal's guidelines for non-ASGI web servers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.