serving admin interface from server #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool dude. I can test more later! Tried a few this AM and looked good. |
|
Stress tested this / tried with all types, different port. I think the only thing that would be good to fix/change would be the admin automatically connecting to the port it's on–e.g. "localhost:9001" would auto connect to 9001. What do you think? |
|
could be nice. |
quinkennedy
added a commit
that referenced
this pull request
Feb 29, 2016
serving admin interface from server
|
fixes #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some minor changes, and tested on Node 5.7.0, I would appreciate it if someone else tested this with a client or two before we merge it into master.