Skip to content

Increase all tolerances to 1e-9 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Increase all tolerances to 1e-9 #226

wants to merge 2 commits into from

Conversation

pklampros
Copy link
Collaborator

No description provided.

@pklampros pklampros requested a review from blsemo August 15, 2018 13:05
blsemo
blsemo reviewed Aug 22, 2018
View reviewed changes
Copy link
Collaborator

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe setting everything to 1e-9 is a bit simplistic. Ideally, we'd look at all the tolerances, figure out what they exactly mean and what values they are usually compared against.

@pklampros pklampros mentioned this pull request Sep 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blsemo blsemo blsemo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pklampros @blsemo