Rename hPA to hPa #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should keep a CHANGELOG file that would need to be updated with every change? |
|
Good point, will add one. |
|
#9 is merged, feel free to rebase. |
dns2utf8
force-pushed
the
hpa-rename
branch
3 times, most recently
from
1b66383 to
646fd4a
Compare
|
Added and rebased |
dbrgn
requested changes
Jan 30, 2017
CHANGELOG.md
Outdated
| @@ -9,4 +9,4 @@ Changes should start with one of the following tags: | |||
|
|
|||
| ## v0.14 (unreleased) | |||
|
|
|||
| - ... | |||
| - [changed] The unit `hPA` was renamed to `hPa` to match the SI unit | |||
There was a problem hiding this comment.
I'd mention where this unit is found:
The unit
hPAinsensors.barometer.unitwas renamed tohPato match the SI unit
|
@dns2utf8 ping |
This should probably be merged after #9
dbrgn
approved these changes
Oct 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.