Only use EC2 creds from our project. Clean up after use.#892
Merged
Conversation
When looking for existing EC2 credentials, we only accept those created for our own project. If we need to create one, remember this and clean it up again. Signed-off-by: Kurt Garloff <kurt@garloff.de>
Member
Author
|
This should avoid issue #890. |
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
mbuechse
reviewed
Mar 19, 2025
Signed-off-by: Kurt Garloff <kurt@garloff.de>
This reverts commit 30af575. Too much complexity for too little gain.
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
Signed-off-by: Matthias Büchse <matthias.buechse@cloudandheat.com>
mbuechse
approved these changes
Mar 20, 2025
Contributor
mbuechse
left a comment
mbuechse
left a comment
There was a problem hiding this comment.
LGTM. I have changed a few bits; the commit messages should explain what I did.
Member
Author
|
Thanks for your improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking for existing EC2 credentials, we only accept those created for our own project.
If we need to create one, remember this and clean it up again.