-
Notifications
You must be signed in to change notification settings - Fork 31
SCS-0123-v2: Clarify mandatory service types #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
toothstone
wants to merge
5
commits into
main
Choose a base branch
from
1004-mandatory-service-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
90eb6fb
Draft clarification on mandatory service types
toothstone dd7917c
Add test definitions for SCS-0123-v2
toothstone ded05b9
Fixup: md lint & link
toothstone 5ce40b0
Fixup: moar link fix
toothstone c25b82b
Fixup: Apply suggestion from @mbuechse
toothstone File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -269,6 +269,9 @@ scripts: | |
| - id: scs-0123-storage-apis | ||
| description: The block-storage API is discoverable as `volume`, `volumev3`, or `block-storage`. | ||
| url: https://docs.scs.community/standards/scs-0123-w1-mandatory-and-supported-IaaS-services-implementation#automated-tests | ||
| - id: scs-0123-service-s3 | ||
| description: s3 service is discoverable. | ||
| url: https://docs.scs.community/standards/scs-0123-w1-mandatory-and-supported-IaaS-services-implementation#automated-tests | ||
| - id: scs-0123-swift-s3 | ||
| description: The object-storage API is compatible with S3. | ||
| url: https://docs.scs.community/standards/scs-0123-w1-mandatory-and-supported-IaaS-services-implementation#automated-tests | ||
|
|
@@ -452,6 +455,18 @@ modules: | |
| - scs-0123-service-object-store | ||
| - scs-0123-storage-apis | ||
| - scs-0123-swift-s3 | ||
| - id: scs-0123-v2 | ||
| name: Mandatory and Supported IaaS Services | ||
| url: https://docs.scs.community/standards/scs-0123-v2-mandatory-and-supported-IaaS-services | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you shorten the slug (as I invited you to do), then this needs to be adjusted. |
||
| targets: | ||
| main: | ||
| - scs-0123-service-compute | ||
| - scs-0123-service-identity | ||
| - scs-0123-service-image | ||
| - scs-0123-service-network | ||
| - scs-0123-service-load-balancer | ||
| - scs-0123-storage-apis | ||
| - scs-0123-service-s3 | ||
| - id: scs-0302-v1 | ||
| name: Domain Manager Role | ||
| url: https://docs.scs.community/standards/scs-0302-v1-domain-manager-role | ||
|
|
@@ -496,7 +511,7 @@ versions: | |
| - scs-0116-v1 | ||
| - scs-0117-v1 | ||
| - scs-0121-v1 | ||
| - scs-0123-v1 | ||
| - scs-0123-v2 | ||
| - scs-0302-v1 | ||
| - version: v5.1 # copy of v5, but with include "scs-0123-v1", which had simply been forgotten | ||
| stabilized_at: 2024-12-19 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be saved under a different name:
Standards/scs-0123-v2-mandatory-and-supported-iaas-services.md(importantly, withv2). Feel free to shorten the slug, though!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I had the notice in the commit message, but it didn't make it to the PR description - I did not create a new file for now to keep the diff easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Not the worst move, to be honest :)