-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement did generator #3
Conversation
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested on the CLI locally (which works 👍). In addition to my inline comments, I have two general suggestions:
- Re-add the README that was part of the original PR that was closed in favor of this one.
- Make it easier to "demo" for someone:
- In order to try the CLI, I had to create a certificate and a key. For this, I reused the test data in created in the
DidGenTestCase
and exported them to files via interactive Python console, which was too cumbersome IMHO. - What can I do with the resulting DID json file? Can I feed it to some other tool?
- In order to try the CLI, I had to create a certificate and a key. For this, I reused the test data in created in the
The last question also makes me think if the DID creation test pipeline could benefit from integration testing with another tool – not maintained by us – which reads a DID and does something with it.
Adding to that: I suggest adding a link to the following two documents, which I found helpful for getting to know Decentralized Identifiers and the context in which they are used: https://w3c-ccg.github.io/did-primer/ and https://w3c.github.io/did-use-cases/ (for the latter one, the "Use Cases" section was helpful in my opinion). |
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Martin Morgenstern <martin.morgenstern@cloudandheat.com> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
You are completely right, I forgot to copy README
Details of DID, DID document and what they can be used for, are explained in W3C DID standard. Of course, without the new README, this is not obvious.
Good point. DID document is required for Gaia-X and its infrastructure is not yet up and running. I will put this in backlog. |
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
@martinmo I added your changes and suggestions please re-review. |
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor points
Co-authored-by: Matthias Büchse <github@mbue.de> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Matthias Büchse <github@mbue.de> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Co-authored-by: Matthias Büchse <github@mbue.de> Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
Signed-off-by: Anja Strunk <anja.strunk@cloudandheat.com>
Signed-off-by: anjastrunk <119566837+anjastrunk@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round of review done – I think this is good to go!
No description provided.