Add monitoring docs and display it on the overview map #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: PR is marked as DRAFT, and will be ready for review after SovereignCloudStack/k8s-observability#44 |
|
Great! I'll take care of the CSS / positioning issue with the box once it's merged. |
matofeder
commented
Feb 20, 2024
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
matofeder
force-pushed
the
add_monitoring_docs
branch
from
a7c62ae to
4885872
Compare
bitkeks
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
After the great work in SovereignCloudStack/k8s-observability#44, this PR LGTM!
3 tasks
maxwolfs
added a commit
that referenced
this pull request
Mar 4, 2024
* remove deprecated parts Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix linkg Signed-off-by: Max Wolfs <mail@maxwolfs.com> * feat: add cluster stacks description Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * refactor components for better reuse with json Signed-off-by: Max Wolfs <mail@maxwolfs.com> * import architecture component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix loading Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add first single components to overview component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Adjust model Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add custom data plugin Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix: typo Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * fix calendar link Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add container registry docs and display it on the overview map (#143) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add monitoring docs and display it on the overview map (#144) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add CSPO docs and display it on the overview map (#149) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * fix component sizing Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add missing k8s-cluster-api-provider doc pages (#152) Signed-off-by: Roman Hros <roman.hros@dnation.cloud> * fix title Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> --------- Signed-off-by: Max Wolfs <mail@maxwolfs.com> Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Matej Feder <matej.feder@dnation.cloud> Signed-off-by: Roman Hros <roman.hros@dnation.cloud> Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Co-authored-by: Matej Feder <matej.feder@dnation.cloud> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
JuanPTM
pushed a commit
to JuanPTM/docs
that referenced
this pull request
Jun 3, 2024
* remove deprecated parts Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix linkg Signed-off-by: Max Wolfs <mail@maxwolfs.com> * feat: add cluster stacks description Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * refactor components for better reuse with json Signed-off-by: Max Wolfs <mail@maxwolfs.com> * import architecture component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix loading Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add first single components to overview component Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Adjust model Signed-off-by: Max Wolfs <mail@maxwolfs.com> * add custom data plugin Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix url Signed-off-by: Max Wolfs <mail@maxwolfs.com> * fix: typo Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> * fix calendar link Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add container registry docs and display it on the overview map (SovereignCloudStack#143) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add monitoring docs and display it on the overview map (SovereignCloudStack#144) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * Add CSPO docs and display it on the overview map (SovereignCloudStack#149) Signed-off-by: Matej Feder <matej.feder@dnation.cloud> * fix component sizing Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Apply suggestions from code review Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> * Add missing k8s-cluster-api-provider doc pages (SovereignCloudStack#152) Signed-off-by: Roman Hros <roman.hros@dnation.cloud> * fix title Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Max Wolfs <mail@maxwolfs.com> --------- Signed-off-by: Max Wolfs <mail@maxwolfs.com> Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Signed-off-by: Matej Feder <matej.feder@dnation.cloud> Signed-off-by: Roman Hros <roman.hros@dnation.cloud> Co-authored-by: Jan Schoone <6106846+jschoone@users.noreply.github.com> Co-authored-by: Filip Dobrovolný <dobrovolny.filip@gmail.com> Co-authored-by: Matej Feder <matej.feder@dnation.cloud> Co-authored-by: Roman Hros <roman.hros@dnation.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds monitoring docs and displays the monitoring on the overview map
Related to #136
@maxwolfs
The monitoring box does not fit the Ops Layer box on the overview map, see here:
What are your preferences here? i.e.: resize the ops layer box only or resize the entire component map?...