Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add oci as assets client #198

Merged
merged 12 commits into from
Sep 10, 2024
Merged

✨ Add oci as assets client #198

merged 12 commits into from
Sep 10, 2024

Conversation

chess-knight
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #194

Special notes for your reviewer:
Based on #197

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
@cluster-stack-bot cluster-stack-bot bot added size/XL Denotes a PR that changes 800-2000 lines, ignoring generated files. area/hack Changes made in the hack directory area/api Changes made in the api directory labels Aug 27, 2024
@chess-knight chess-knight force-pushed the feat/oci-client branch 2 times, most recently from 60a59c8 to 6e4dfb6 Compare August 27, 2024 13:45
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
@cluster-stack-bot cluster-stack-bot bot added the area/github Changes made in the github directory label Aug 28, 2024
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
@chess-knight
Copy link
Member Author

Hi @jschoone. This PR is ready for the review. It uses a pseudo version of CSO generated from the specific commit (go get github.com/SovereignCloudStack/cluster-stack-operator@oci-client). I also added basic auth there, see SovereignCloudStack/cluster-stack-operator#238.

The only problem is with integration tests. I am trying to use registry.scs.community/csctl-oci/openstack:openstack-scs-1-28-v0-sha-umng5ie and it works from my local machine (csctl publish command tagged it with dot version tag so I manually created "correct" dashed version tag). But I am not able to successfully run it from this PR (GitHub Actions), it errors out with connection reset by peer which I don't understand so far. Then I switch to registry.dnation.cloud and it just works(current state of the PR).

I don't know why pulling from the SCS Registry works from my local machine but doesn't work from GitHub. I tried to debug it but I only found a similar issue goharbor/harbor#11260 (comment).

jschoone and others added 4 commits August 30, 2024 14:50
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Copy link
Contributor

@jschoone jschoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
@chess-knight chess-knight merged commit c7a9268 into main Sep 10, 2024
7 checks passed
@chess-knight chess-knight deleted the feat/oci-client branch September 10, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory area/github Changes made in the github directory area/hack Changes made in the hack directory size/XL Denotes a PR that changes 800-2000 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OCI client
2 participants