add wireguard fragmentation helpers#82
Merged
FlorianUekermann merged 1 commit intov0from Feb 23, 2026
Merged
Conversation
FlorianUekermann
force-pushed
the
florian/obs-3199-fragmentation-support-shared-code-in-api-crate
branch
5 times, most recently
from
7531c51 to
c49b4f1
Compare
kevincox
approved these changes
Feb 23, 2026
src/wg_fragment/mod.rs
Outdated
|
|
||
| const WG_FRAGMENT_MESSAGE_TYPE: u8 = 170; | ||
|
|
||
| const OVERHEAD: usize = 1 // message type |
Collaborator
There was a problem hiding this comment.
Suggested change
| const OVERHEAD: usize = 1 // message type | |
| const FRAGMENT_META_OVERHEAD: usize = 1 // message type |
Just "overhead" is very vague. I also wouldn't mind FRAGMENT_HEADER_SIZE, FRAGMENT_HEADER_SIZE or similar.
| pub mod merge; | ||
| pub mod split; | ||
|
|
||
| const WG_FRAGMENT_MESSAGE_TYPE: u8 = 170; |
Collaborator
There was a problem hiding this comment.
Can we add a comment with where this magic value comes from? (AKA what values are used by wireguard and what range we can use)
FlorianUekermann
force-pushed
the
florian/obs-3199-fragmentation-support-shared-code-in-api-crate
branch
from
c49b4f1 to
58aeaf3
Compare
FlorianUekermann
deleted the
florian/obs-3199-fragmentation-support-shared-code-in-api-crate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.