Draft
Conversation
kevincox
approved these changes
Jan 21, 2026
| let res = self.send_http(request).await?; | ||
| let res = parse_response::<AcquireToken2Output>(res).await?; | ||
| let mut pow = None; | ||
| let res = loop { |
| #[derive(Debug, Serialize, Deserialize, Clone)] | ||
| pub struct AcquireToken { | ||
| pub account_id: AccountId, | ||
| pub pow: Option<PowOutput>, |
Collaborator
There was a problem hiding this comment.
Nit: Expand this or at least add a doc comment.
| })) = &res | ||
| && pow.is_none() | ||
| { | ||
| pow = Some(pow_input.solve(&account_id)); |
Collaborator
There was a problem hiding this comment.
I think the hard part of this is that we should be giving client feedback. But we can add that later. There are basically two cases:
- We return trivial PoW challenges, deterring lazy people. UI change is not necessary.
- We return difficult challenges, hopefully adding notable cost. UI change seems pretty important.
|
|
||
| #[derive(Clone, Debug, Deserialize, Serialize, PartialEq)] | ||
| pub struct PowInput { | ||
| pub nonce: u128, |
Contributor
Author
There was a problem hiding this comment.
decided to use string
| #[derive(Clone, Debug, Deserialize, Serialize)] | ||
| pub struct PowOutput { | ||
| pub nonce: u128, | ||
| pub solutions: Vec<u128>, |
Contributor
Author
There was a problem hiding this comment.
decided to use strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
untested draft for API decisions