-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create an example of an API server using fault #35
Conversation
Thanks for this, I will take a look at this soon! I did also remove go.work as advised by this issue but we can still keep a nested go.mod. |
Looks good, sorry this took me so long to get around to reviewing! I left a couple of questions, but nothing blocking. |
I will do a bit of rework when I'm back from vacation. Thanks for the review. |
73ad654
to
99c2af8
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 3 3
Lines 69 69
=======================================
Hits 62 62
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
99c2af8
to
32821a6
Compare
Hey, sorry this took so long! Keen to merge unless there are any minor things you want to tackle. I think once the standard library has that new HTTP router, we can even remove chi, but for now the dependency is fine. Nice work btw, thank you for the contribution! |
Let me remove the |
To avoid exposing the "internal" part of the stacktraces and to keep the example simpler, we'll just use the default %+v format output.
Done. Feel free to merge when ready. |
I created a workspace project to demonstrate some features of fault in a REST api context.