Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create an example of an API server using fault #35

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

matdurand
Copy link
Contributor

I created a workspace project to demonstrate some features of fault in a REST api context.

examples/api/http/http.go Outdated Show resolved Hide resolved
@Southclaws
Copy link
Owner

Southclaws commented Jul 6, 2023

Thanks for this, I will take a look at this soon!

I did also remove go.work as advised by this issue but we can still keep a nested go.mod.

@Southclaws
Copy link
Owner

Looks good, sorry this took me so long to get around to reviewing!

I left a couple of questions, but nothing blocking.

@matdurand
Copy link
Contributor Author

I will do a bit of rework when I'm back from vacation. Thanks for the review.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f02308e) 89.85% compared to head (61dc5a6) 89.85%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files           3        3           
  Lines          69       69           
=======================================
  Hits           62       62           
  Misses          5        5           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Southclaws
Copy link
Owner

Hey, sorry this took so long! Keen to merge unless there are any minor things you want to tackle.

I think once the standard library has that new HTTP router, we can even remove chi, but for now the dependency is fine. Nice work btw, thank you for the contribution!

@matdurand
Copy link
Contributor Author

Let me remove the internal section in favor of using format instead and then we're good to merge!

To avoid exposing the "internal" part of the stacktraces and to keep
the example simpler, we'll just use the default %+v format output.
@matdurand
Copy link
Contributor Author

Done. Feel free to merge when ready.

@Southclaws Southclaws merged commit 84c038e into Southclaws:master Sep 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants