Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 28: fix wrong location of some errors #30

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

matdurand
Copy link
Contributor

@matdurand matdurand commented Jun 1, 2023

Fixes part of #28
This change introduce the following in the flatten method:

  • non-fault error results in a step without a location
  • all context (ftag, fmsg) attached to a wrap call will share the same location
  • fault.New will use its own location
  • empty .Wrap(err) function results in a Step with a location but without message

@matdurand matdurand changed the title fix: issue 28 wrong location of some errors issue 28: fix wrong location of some errors Jun 1, 2023
Copy link
Owner

@Southclaws Southclaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant thanks! It's great to see more location info in those error chains, but not as noisy as a full stack trace.

@Southclaws Southclaws merged commit 1be749f into Southclaws:master Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants