Skip to content

Conversation

@Dyst0rti0n
Copy link

The Refresh() method in the file explorer model could lead to a nil pointer dereference with different flaws:

  • Ignored the error from filetree.CreateTree()
  • Used flawed logic to re-select a node, which could result
    in an index of -1.

@NucleoFusion
Copy link
Member

I came across another error yesterday in file explorer, a user should not be allowed to delete the root folder. While he is allowed rn i beleive.
All in all looks pretty good, and I'll get on it in a while.

@Dyst0rti0n
Copy link
Author

I came across another error yesterday in file explorer, a user should not be allowed to delete the root folder. While he is allowed rn i beleive. All in all looks pretty good, and I'll get on it in a while.

AH yes that would occur actually, nice spot. Going to do a bit more tonight and get more understanding into the code. Very nice build thus far I might say. Great project and it's wrote in the holy grail - Go

@NucleoFusion
Copy link
Member

Thank! Means a lot
Tbh it's my first big project anywhere that has gained traction, and I was unsure if I did it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants