Fixed a typo in the validation tag for Prometheus port (kubeflow#649)

Souheil-Yazji · Oct 2, 2019 · f783611 · f783611
1 parent 22e51f2
commit f783611
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/manifest/crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml b/manifest/crds/sparkoperator.k8s.io_scheduledsparkapplications.yaml
@@ -1903,7 +1903,8 @@ spec:
                           type: string
                         port:
                           format: int32
-                          minimum: 49151
+                          minimum: 1024
+                          maximum: 49151
                           type: integer
                       required:
                       - jmxExporterJar

diff --git a/manifest/crds/sparkoperator.k8s.io_sparkapplications.yaml b/manifest/crds/sparkoperator.k8s.io_sparkapplications.yaml
@@ -1889,7 +1889,8 @@ spec:
                       type: string
                     port:
                       format: int32
-                      minimum: 49151
+                      minimum: 1024
+                      maximum: 49151
                       type: integer
                   required:
                   - jmxExporterJar

diff --git a/pkg/apis/sparkoperator.k8s.io/v1beta2/types.go b/pkg/apis/sparkoperator.k8s.io/v1beta2/types.go
@@ -543,7 +543,7 @@ type PrometheusSpec struct {
 	// Optional.
 	// If not specified, 8090 will be used as the default.
 	// +kubebuilder:validation:Minimum=1024
-	// +kubebuilder:validation:Minimum=49151
+	// +kubebuilder:validation:Maximum=49151
 	Port *int32 `json:"port,omitempty"`
 	// ConfigFile is the path to the custom Prometheus configuration file provided in the Spark image.
 	// ConfigFile takes precedence over Configuration, which is shown below.