[bug] Uncaught TypeError: Cannot assign to read only property 'chosen' of object '#<Object>' since upgrade to v6.1.0

[Saul-Mirone]

Describe the bug
After upgrate the react-sortablejs version from 6.0.3 to 6.1.0, I got this error everytime I click on my sortable list:

Uncaught TypeError: Cannot assign to read only property 'chosen' of object '#<Object>'

To Reproduce
Steps to reproduce the behavior:

1. Go to my repo: https://github.com/Saul-Mirone/vite-plugin-book
2. Upgrade the react-sortablejs version to 6.1.0 in packages/vite-plugin-book/package.json
3. Run pnpm install, pnpm dev and pnpm doc in root
4. Click on the sidebar and see error.

Expected behavior
Just work normally as v6.0.3

Information
Uncaught TypeError: Cannot assign to read only property 'chosen' of object '#'

Versions - Look in your package.json for this information:
react-sortable = ^6.0.3
react = ^x.x.x

Additional context
I use nested sortable list.

[Saul-Mirone]

Update:
Is it possible that it's caused by this PR?
#226

[andresin87]

It's the only feature added in 6.1
https://github.com/SortableJS/react-sortablejs/blame/fa174685ac028135ef9d422c3fef00751deb83eb/src/react-sortable.tsx#L54

[Saul-Mirone]

Still don't know why but things work fine after I made this change:
Saul-Mirone/vite-plugin-book@b949839#diff-811aee71034d5086fa8e1e23d182c2f20de005829cb071a0c1a0cf2cf4476a02R58

[conduct0]

Still don't know why but things work fine after I made this change: Saul-Mirone/vite-plugin-book@b949839#diff-811aee71034d5086fa8e1e23d182c2f20de005829cb071a0c1a0cf2cf4476a02R58

I think it is because if you destructure the object, even if it was frozen by immer or something like that, will send a copy that can be modified. From what I saw the object is being mutated here:

// make all state false because we can't change sortable unless a mouse gesture is made.
const newList = [...props.list].map(item => Object.assign(item, {
  chosen: false,
  selected: false
}));

If I for example would make a shallow copy of item like this it wouldn't modify the original frozen object:

const newList = [...props.list].map(item => Object.assign({...item}, {
  chosen: false,
  selected: false
}));

What do you think about updating this method here?
I would be happy to submit a pull request.

[henryobiaraije]

Any fix for this yet?