Add getContainer option for better react version support
#571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubaXa
added a commit
that referenced
this pull request
Sep 24, 2015
Add `getContainer` option for better react version support
Collaborator
|
Ok. |
RubaXa
added a commit
that referenced
this pull request
Oct 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if this fails CI or something..I wrote this in the github editor, since its simple. I can be a more thorough a bit later if you'd like.
react 0.14 deprecates .getDOMNode() so this PR maintains the current default but allows it to be configured, effectively removing the version specific React dependence.
Thanks for the great library!