Skip to content

Allow changing facebook parser and change default parser to json #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 10, 2017
Merged

Allow changing facebook parser and change default parser to json #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d47360
Make facebook provider use json access token parser
Mar 29, 2017
3313286
changed parse attr to read/write
Waynenabors Mar 28, 2017
164e69f
add facebook.parse to config
Waynenabors Mar 28, 2017
79b69a8
Change default api_version and parse configs to v2.3 and :json respec…
joshbuker Mar 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/generators/sorcery/templates/initializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@
# config.facebook.user_info_mapping = {:email => "name"}
# config.facebook.access_permissions = ["email", "publish_actions"]
# config.facebook.display = "page"
# config.facebook.api_version = "v2.2"
# config.facebook.api_version = "v2.3"
# config.facebook.parse = :json
#
# config.github.key = ""
# config.github.secret = ""
Expand Down
6 changes: 3 additions & 3 deletions lib/sorcery/providers/facebook.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ module Providers
class Facebook < Base
include Protocols::Oauth2

attr_reader :mode, :param_name, :parse
attr_reader :mode, :param_name
attr_accessor :access_permissions, :display, :scope, :token_url,
:user_info_path, :auth_path, :api_version
:user_info_path, :auth_path, :api_version, :parse

def initialize
super
Expand All @@ -24,7 +24,7 @@ def initialize
@token_url = 'oauth/access_token'
@auth_path = 'dialog/oauth'
@mode = :query
@parse = :query
@parse = :json
@param_name = 'access_token'
end

Expand Down