Skip to content

fix: modify nodeModulesPath to detect correct path for android build #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

john-mayacrew
Copy link

안드로이드 빌드 시 node_modules에서 @bravemobile/react-native-code-push가 아닌 react-native-code-push를 찾으려고 해, 올바른 경로를 찾지 못하는 문제가 발생하는 것 같습니다.

@floydkim floydkim self-requested a review February 16, 2025 12:03
Copy link
Member

@floydkim floydkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중요한 문제를 발견하고 기여해주셔서 감사합니다.

@floydkim floydkim merged commit 2a6157b into Soomgo-Mobile:master Feb 17, 2025
1 check passed
@floydkim
Copy link
Member

@john-mayacrew 안녕하세요, 해당 PR은 9.0.0-beta.4 버전으로 우선 배포되었습니다.

@john-mayacrew
Copy link
Author

덕분에 라이브러리 잘 쓰고 있습니다. 감사합니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants