Remove AppCenter API call logic #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dekim1028 |
floydkim
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM!
In the future, we plan to re-implement the telemetry functionality we are currently removing and provide library users with the option to implement their own means of telemetry.
Therefore, I considered leaving the existing telemetry function call code; however, as the existing code is implemented in somewhat legacy syntax and it does not seem difficult to identify the reporting points later, it seems better to cleanly remove the code for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36