Skip to content

Commit

Permalink
ipc: remove braces for single statements
Browse files Browse the repository at this point in the history
Deal with checkpatch messages:
     WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
Cc: Aswin Chandramouleeswaran <aswin@hp.com>
Cc: Rik van Riel <riel@redhat.com>
Acked-by: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Davidlohr Bueso authored and torvalds committed Jan 28, 2014
1 parent 8001c85 commit 3ab08fe
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 19 deletions.
18 changes: 9 additions & 9 deletions ipc/compat.c
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,11 @@ static long do_compat_semctl(int first, int second, int third, u32 pad)
break;

case IPC_SET:
if (version == IPC_64) {
if (version == IPC_64)
err = get_compat_semid64_ds(&s64, compat_ptr(pad));
} else {
else
err = get_compat_semid_ds(&s64, compat_ptr(pad));
}

up64 = compat_alloc_user_space(sizeof(s64));
if (copy_to_user(up64, &s64, sizeof(s64)))
err = -EFAULT;
Expand Down Expand Up @@ -515,11 +515,11 @@ long compat_sys_msgctl(int first, int second, void __user *uptr)
break;

case IPC_SET:
if (version == IPC_64) {
if (version == IPC_64)
err = get_compat_msqid64(&m64, uptr);
} else {
else
err = get_compat_msqid(&m64, uptr);
}

if (err)
break;
p = compat_alloc_user_space(sizeof(m64));
Expand Down Expand Up @@ -702,11 +702,11 @@ long compat_sys_shmctl(int first, int second, void __user *uptr)


case IPC_SET:
if (version == IPC_64) {
if (version == IPC_64)
err = get_compat_shmid64_ds(&s64, uptr);
} else {
else
err = get_compat_shmid_ds(&s64, uptr);
}

if (err)
break;
p = compat_alloc_user_space(sizeof(s64));
Expand Down
6 changes: 3 additions & 3 deletions ipc/mqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -1303,11 +1303,11 @@ SYSCALL_DEFINE2(mq_notify, mqd_t, mqdes,
out_fput:
fdput(f);
out:
if (sock) {
if (sock)
netlink_detachskb(sock, nc);
} else if (nc) {
else if (nc)
dev_kfree_skb(nc);
}

return ret;
}

Expand Down
8 changes: 3 additions & 5 deletions ipc/sem.c
Original file line number Diff line number Diff line change
Expand Up @@ -492,9 +492,9 @@ static int newary(struct ipc_namespace *ns, struct ipc_params *params)

size = sizeof(*sma) + nsems * sizeof(struct sem);
sma = ipc_rcu_alloc(size);
if (!sma) {
if (!sma)
return -ENOMEM;
}

memset(sma, 0, size);

sma->sem_perm.mode = (semflg & S_IRWXUGO);
Expand Down Expand Up @@ -1967,10 +1967,8 @@ SYSCALL_DEFINE4(semtimedop, int, semid, struct sembuf __user *, tsops,
* If queue.status != -EINTR we are woken up by another process.
* Leave without unlink_queue(), but with sem_unlock().
*/

if (error != -EINTR) {
if (error != -EINTR)
goto out_unlock_free;
}

/*
* If an interrupt occurred we have to clean up the queue
Expand Down
3 changes: 1 addition & 2 deletions ipc/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,8 @@ void __init ipc_init_proc_interface(const char *path, const char *header,
NULL, /* parent dir */
&sysvipc_proc_fops,
iface);
if (!pde) {
if (!pde)
kfree(iface);
}
}
#endif

Expand Down

0 comments on commit 3ab08fe

Please sign in to comment.