Repository navigation
fix(test): tighten waitForURL in E2E spec 100 to match edit redirect - #1079
Merged
Merged
Conversation
POST create redirects to /admin/content/<ID>/edit, not the list. The broad /\/admin\/content/ pattern matched the current new-form URL immediately, racing with the HTMX submission and causing ERR_ABORTED on the subsequent page.goto call. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
waitForURL(/\/admin\/content/)in the create test matched the current URL/admin/content/new?collection=exampleimmediately — before the HTMX form submission completed. The subsequentpage.goto('/admin/content?collection=example')raced with the in-flight POST, causingnet::ERR_ABORTED.Fix
Wait for the POST success redirect pattern
/admin/content/<ID>/editinstead. The create handler redirects to/admin/content/${doc.rootId}/edit?success=...on success, which is unambiguous.Test plan
🤖 Generated with Claude Code