Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix known bugs in feat_bot #363

Merged
merged 5 commits into from
Jun 8, 2023
Merged

fix: fix known bugs in feat_bot #363

merged 5 commits into from
Jun 8, 2023

Conversation

mmagi
Copy link
Contributor

@mmagi mmagi commented Jun 7, 2023 •
edited
Loading

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并，Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过，并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

fix known bugs in #345

@mmagi mmagi changed the title [WIP]fix: fix known bugs in feat_bot #345 fix: fix known bugs in feat_bot https://github.com/SonicCloudOrg/sonic-server/pull/345 Jun 7, 2023
@mmagi mmagi removed the feature label Jun 7, 2023
@mmagi mmagi changed the title fix: fix known bugs in feat_bot https://github.com/SonicCloudOrg/sonic-server/pull/345 fix: fix known bugs in feat_bot Jun 7, 2023
@prlabeler prlabeler bot added the feature label Jun 7, 2023
@mmagi mmagi removed the feature label Jun 7, 2023
@prlabeler prlabeler bot added the feature label Jun 7, 2023
ZhouYixun
ZhouYixun reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个文件辛苦format一下格式吧

ZhouYixun
ZhouYixun approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@ZhouYixun ZhouYixun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交，辛苦了

@mmagi
Copy link
Contributor Author

mmagi commented Jun 8, 2023

这几个文件辛苦format一下格式吧

变动部分基本都按IDEA的默认设置format过了，看还有哪个不符合习惯的我再单独改一下？

@ZhouYixun
Copy link
Member

image

这里是不是漏了format

@mmagi
Copy link
Contributor Author

mmagi commented Jun 8, 2023

image

这里是不是漏了format

已更正，感谢指出

@ZhouYixun ZhouYixun merged commit 90d3862 into SonicCloudOrg:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhouYixun ZhouYixun ZhouYixun approved these changes

Assignees
No one assigned
Labels
feature fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmagi @ZhouYixun