fix(noon): the disabled flag will works as expected

before this fix it was working as an enabled flag
Sonia-corporation · Oct 31, 2020 · cfc68f9 · cfc68f9
1 parent 5ed27be
commit cfc68f9
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 19 deletions.
diff --git a/...mmand/feature/features/noon/classes/discord-message-command-feature-noon-disabled.spec.ts b/...mmand/feature/features/noon/classes/discord-message-command-feature-noon-disabled.spec.ts
@@ -1427,26 +1427,60 @@ describe(`DiscordMessageCommandFeatureNoonDisabled`, (): void => {
         firebaseGuild.id = `dummy-id`;
       });
 
-      it(`should update the disable state for the feature command in the Firebase guilds`, async (): Promise<
-        void
-      > => {
-        expect.assertions(3);
+      describe(`when the new state is not disabled`, (): void => {
+        beforeEach((): void => {
+          shouldDisable = false;
+        });
 
-        await expect(
-          service.updateDatabase(
-            shouldDisable,
-            isDisabled,
-            firebaseGuild,
-            channel
-          )
-        ).rejects.toThrow(new Error(`updateState error`));
+        it(`should update the enable state to enabled for the feature command in the Firebase guilds`, async (): Promise<
+          void
+        > => {
+          expect.assertions(3);
 
-        expect(
-          firebaseGuildsChannelsFeaturesNoonEnabledServiceUpdateStateByGuildIdSpy
-        ).toHaveBeenCalledTimes(1);
-        expect(
-          firebaseGuildsChannelsFeaturesNoonEnabledServiceUpdateStateByGuildIdSpy
-        ).toHaveBeenCalledWith(`dummy-id`, `dummy-channel-id`, false);
+          await expect(
+            service.updateDatabase(
+              shouldDisable,
+              isDisabled,
+              firebaseGuild,
+              channel
+            )
+          ).rejects.toThrow(new Error(`updateState error`));
+
+          expect(
+            firebaseGuildsChannelsFeaturesNoonEnabledServiceUpdateStateByGuildIdSpy
+          ).toHaveBeenCalledTimes(1);
+          expect(
+            firebaseGuildsChannelsFeaturesNoonEnabledServiceUpdateStateByGuildIdSpy
+          ).toHaveBeenCalledWith(`dummy-id`, `dummy-channel-id`, true);
+        });
+      });
+
+      describe(`when the new state is disabled`, (): void => {
+        beforeEach((): void => {
+          shouldDisable = true;
+        });
+
+        it(`should update the enable state to not enabled for the feature command in the Firebase guilds`, async (): Promise<
+          void
+        > => {
+          expect.assertions(3);
+
+          await expect(
+            service.updateDatabase(
+              shouldDisable,
+              isDisabled,
+              firebaseGuild,
+              channel
+            )
+          ).rejects.toThrow(new Error(`updateState error`));
+
+          expect(
+            firebaseGuildsChannelsFeaturesNoonEnabledServiceUpdateStateByGuildIdSpy
+          ).toHaveBeenCalledTimes(1);
+          expect(
+            firebaseGuildsChannelsFeaturesNoonEnabledServiceUpdateStateByGuildIdSpy
+          ).toHaveBeenCalledWith(`dummy-id`, `dummy-channel-id`, false);
+        });
       });
 
       describe(`when the disable state for the feature command in the Firebase guilds was not successfully updated`, (): void => {

diff --git a/...es/command/feature/features/noon/classes/discord-message-command-feature-noon-disabled.ts b/...es/command/feature/features/noon/classes/discord-message-command-feature-noon-disabled.ts
@@ -91,7 +91,7 @@ export class DiscordMessageCommandFeatureNoonDisabled
   ): Promise<IDiscordCommandFlagSuccess> {
     if (!_.isNil(id)) {
       return FirebaseGuildsChannelsFeaturesNoonEnabledService.getInstance()
-        .updateStateByGuildId(id, discordChannel.id, shouldDisable)
+        .updateStateByGuildId(id, discordChannel.id, !shouldDisable)
         .then(
           (): Promise<IDiscordCommandFlagSuccess> =>
             Promise.resolve(