fix(messages): allow to send empty messages with only embeds. (#1849)

src/features/discord/logger/services/__mocks__/discord-logger-error.service.ts

@@ -25,7 +25,6 @@ export class DiscordLoggerErrorService extends AbstractService {
 
   public getErrorMessageResponse(): IDiscordMessageResponse {
     return {
-      content: ``,
       options: {
         embeds: [createMock<MessageEmbed>()],
       },

src/features/discord/logger/services/discord-logger-error.service.spec.ts

@@ -440,7 +440,7 @@ describe(`DiscordLoggerErrorService`, (): void => {
 
       const result = service.getErrorMessageResponse(error);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/logger/services/discord-logger-error.service.ts

@@ -51,7 +51,6 @@ export class DiscordLoggerErrorService extends AbstractService {
 
   public getErrorMessageResponse(error: Readonly<Error | string>): IDiscordMessageResponse {
     return {
-      content: ``,
       options: {
         embeds: [this._getMessageEmbed(error)],
       },

src/features/discord/logger/services/discord-logger-warning.service.spec.ts

@@ -269,7 +269,7 @@ describe(`DiscordLoggerWarningService`, (): void => {
 
       const result = service.getWarningMessageResponse(warning);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/logger/services/discord-logger-warning.service.ts

@@ -44,7 +44,6 @@ export class DiscordLoggerWarningService extends AbstractService {
 
   public getWarningMessageResponse(warning: Readonly<string>): IDiscordMessageResponse {
     return {
-      content: ``,
       options: {
         embeds: [this._getMessageEmbed(warning)],
       },

src/features/discord/messages/interfaces/discord-message-response.ts

@@ -1,6 +1,6 @@
 import { IDiscordMessageOptions } from '../types/discord-message-options';
 
 export interface IDiscordMessageResponse {
-  content: string;
+  content?: string;
   readonly options: IDiscordMessageOptions;
 }

src/features/discord/messages/services/command/cookie/services/__mocks__/discord-message-command-cookie.service.ts

@@ -26,7 +26,6 @@ export class DiscordMessageCommandCookieService extends AbstractService {
 
   public getMessageResponse(): IDiscordMessageResponse {
     return {
-      content: ``,
       options: {
         embeds: [createMock<MessageEmbed>()],
       },

src/features/discord/messages/services/command/cookie/services/discord-message-command-cookie.service.spec.ts

@@ -261,7 +261,7 @@ describe(`DiscordMessageCommandCookieService`, (): void => {
 
       const result = await service.handleResponse(anyDiscordMessage);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 

src/features/discord/messages/services/command/cookie/services/discord-message-command-cookie.service.ts

@@ -40,7 +40,6 @@ export class DiscordMessageCommandCookieService extends AbstractService {
 
   public getMessageResponse(): Promise<IDiscordMessageResponse> {
     const message: IDiscordMessageResponse = {
-      content: ``,
       options: {
         embeds: [this._getMessageEmbed()],
       },

src/features/discord/messages/services/command/discord-message-command-cli-error.service.spec.ts

@@ -174,7 +174,7 @@ describe(`DiscordMessageCommandCliErrorService`, (): void => {
 
       const result = await service.getCliErrorMessageResponse();
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/discord-message-command-cli-error.service.ts

@@ -30,7 +30,6 @@ export class DiscordMessageCommandCliErrorService extends AbstractService {
    */
   public getCliErrorMessageResponse(): Promise<IDiscordMessageResponse> {
     const message: IDiscordMessageResponse = {
-      content: ``,
       options: {
         embeds: [this._getMessageEmbed()],
       },

src/features/discord/messages/services/command/error/discord-message-command-error.service.spec.ts

@@ -277,7 +277,7 @@ describe(`DiscordMessageCommandErrorService`, (): void => {
 
       const result = await service.handleResponse(anyDiscordMessage);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 

src/features/discord/messages/services/command/error/discord-message-command-error.service.ts

@@ -44,7 +44,6 @@ export class DiscordMessageCommandErrorService extends AbstractService {
 
   public getMessageResponse(): Promise<IDiscordMessageResponse> {
     const message: IDiscordMessageResponse = {
-      content: ``,
       options: {
         embeds: [this._getMessageEmbed()],
       },

src/features/discord/messages/services/command/feature/features/noon/classes/discord-message-command-feature-noon-help.spec.ts

@@ -457,7 +457,7 @@ describe(`DiscordMessageCommandFeatureNoonHelp`, (): void => {
 
         const result = await service.getMessageResponse(anyDiscordMessage, discordCommandFlags);
 
-        expect(result.content).toBe(``);
+        expect(result.content).toBeUndefined();
       });
     });
   });

src/features/discord/messages/services/command/feature/features/noon/classes/discord-message-command-feature-noon-help.ts

@@ -33,7 +33,6 @@ export class DiscordMessageCommandFeatureNoonHelp<T extends string> implements D
       .getMessageResponse()
       .then((helpMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(anyDiscordMessage, discordCommandFlags)],
           },

src/features/discord/messages/services/command/feature/features/noon/classes/discord-message-command-feature-noon-humanize.spec.ts

@@ -825,7 +825,7 @@ describe(`DiscordMessageCommandFeatureNoonHumanize`, (): void => {
 
         const result = await service.getMessageResponse(state);
 
-        expect(result.content).toBe(``);
+        expect(result.content).toBeUndefined();
       });
     });
   });

src/features/discord/messages/services/command/feature/features/noon/classes/discord-message-command-feature-noon-humanize.ts

@@ -64,7 +64,6 @@ export class DiscordMessageCommandFeatureNoonHumanize<T extends string>
       .getMessageResponse()
       .then((helpMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(state)],
           },

src/features/discord/messages/services/command/feature/features/noon/services/discord-message-command-feature-noon.service.spec.ts

@@ -335,7 +335,7 @@ describe(`DiscordMessageCommandFeatureNoonService`, (): void => {
 
           const result = await service.getMessageResponse(anyDiscordMessage, messageFlags);
 
-          expect(result[0].content).toBe(``);
+          expect(result[0].content).toBeUndefined();
         });
       });
 
@@ -481,7 +481,7 @@ describe(`DiscordMessageCommandFeatureNoonService`, (): void => {
 
           const result = await service.getMessageResponse(anyDiscordMessage, messageFlags);
 
-          expect(result[0].content).toBe(``);
+          expect(result[0].content).toBeUndefined();
         });
       });
 
@@ -703,7 +703,7 @@ describe(`DiscordMessageCommandFeatureNoonService`, (): void => {
 
           const result = await service.getMessageResponse(anyDiscordMessage, messageFlags);
 
-          expect(result[0].content).toBe(``);
+          expect(result[0].content).toBeUndefined();
         });
       });
     });

src/features/discord/messages/services/command/feature/features/noon/services/discord-message-command-feature-noon.service.ts

@@ -72,7 +72,6 @@ export class DiscordMessageCommandFeatureNoonService extends AbstractService {
 
         if (!_.isEmpty(discordCommandSplittedFlagsResponse.commandFlagsSuccess)) {
           discordMessageResponses.unshift({
-            content: ``,
             options: {
               embeds: [this._getMessageEmbed(discordCommandSplittedFlagsResponse.commandFlagsSuccess)],
             },

src/features/discord/messages/services/command/feature/features/release-notes/classes/discord-message-command-feature-release-notes-help.spec.ts

@@ -457,7 +457,7 @@ describe(`DiscordMessageCommandFeatureReleaseNotesHelp`, (): void => {
 
         const result = await service.getMessageResponse(anyDiscordMessage, discordCommandFlags);
 
-        expect(result.content).toBe(``);
+        expect(result.content).toBeUndefined();
       });
     });
   });

src/features/discord/messages/services/command/feature/features/release-notes/classes/discord-message-command-feature-release-notes-help.ts

@@ -35,7 +35,6 @@ export class DiscordMessageCommandFeatureReleaseNotesHelp<T extends string>
       .getMessageResponse()
       .then((helpMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(anyDiscordMessage, discordCommandFlags)],
           },

src/features/discord/messages/services/command/feature/features/release-notes/classes/discord-message-command-feature-release-notes-humanize.spec.ts

@@ -876,7 +876,7 @@ describe(`DiscordMessageCommandFeatureReleaseNotesHumanize`, (): void => {
 
         const result = await service.getMessageResponse(state);
 
-        expect(result.content).toBe(``);
+        expect(result.content).toBeUndefined();
       });
     });
   });

src/features/discord/messages/services/command/feature/features/release-notes/classes/discord-message-command-feature-release-notes-humanize.ts

@@ -70,7 +70,6 @@ export class DiscordMessageCommandFeatureReleaseNotesHumanize<T extends string>
       .getMessageResponse()
       .then((helpMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(state)],
           },

src/features/discord/messages/services/command/feature/features/release-notes/services/discord-message-command-feature-release-notes.service.spec.ts

@@ -342,7 +342,7 @@ describe(`DiscordMessageCommandFeatureReleaseNotesService`, (): void => {
 
           const result = await service.getMessageResponse(anyDiscordMessage, messageFlags);
 
-          expect(result[0].content).toBe(``);
+          expect(result[0].content).toBeUndefined();
         });
       });
 
@@ -490,7 +490,7 @@ describe(`DiscordMessageCommandFeatureReleaseNotesService`, (): void => {
 
           const result = await service.getMessageResponse(anyDiscordMessage, messageFlags);
 
-          expect(result[0].content).toBe(``);
+          expect(result[0].content).toBeUndefined();
         });
       });
 
@@ -714,7 +714,7 @@ describe(`DiscordMessageCommandFeatureReleaseNotesService`, (): void => {
 
           const result = await service.getMessageResponse(anyDiscordMessage, messageFlags);
 
-          expect(result[0].content).toBe(``);
+          expect(result[0].content).toBeUndefined();
         });
       });
     });

src/features/discord/messages/services/command/feature/features/release-notes/services/discord-message-command-feature-release-notes.service.ts

@@ -72,7 +72,6 @@ export class DiscordMessageCommandFeatureReleaseNotesService extends AbstractSer
 
         if (!_.isEmpty(discordCommandSplittedFlagsResponse.commandFlagsSuccess)) {
           discordMessageResponses.unshift({
-            content: ``,
             options: {
               embeds: [this._getMessageEmbed(discordCommandSplittedFlagsResponse.commandFlagsSuccess)],
             },

src/features/discord/messages/services/command/feature/services/discord-message-command-feature-empty-content-error.service.spec.ts

@@ -246,7 +246,7 @@ describe(`DiscordMessageCommandFeatureEmptyContentErrorService`, (): void => {
 
       const result = await service.getMessageResponse();
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/discord-message-command-feature-empty-content-error.service.ts

@@ -28,7 +28,6 @@ export class DiscordMessageCommandFeatureEmptyContentErrorService extends Discor
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed()],
           },

src/features/discord/messages/services/command/feature/services/feature-names/discord-message-command-feature-empty-feature-name-error.service.spec.ts

@@ -361,7 +361,7 @@ describe(`DiscordMessageCommandFeatureEmptyFeatureNameErrorService`, (): void =>
 
       const result = await service.getMessageResponse(anyDiscordMessage, commands);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/feature-names/discord-message-command-feature-empty-feature-name-error.service.ts

@@ -31,7 +31,6 @@ export class DiscordMessageCommandFeatureEmptyFeatureNameErrorService extends Di
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(anyDiscordMessage, commands)],
           },

src/features/discord/messages/services/command/feature/services/feature-names/discord-message-command-feature-wrong-feature-name-error.service.spec.ts

@@ -363,7 +363,7 @@ describe(`DiscordMessageCommandFeatureWrongFeatureNameErrorService`, (): void =>
 
       const result = await service.getMessageResponse(anyDiscordMessage, commands, featureName);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/feature-names/discord-message-command-feature-wrong-feature-name-error.service.ts

@@ -32,7 +32,6 @@ export class DiscordMessageCommandFeatureWrongFeatureNameErrorService extends Di
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(anyDiscordMessage, commands, featureName)],
           },

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-duplicated-flags-error.service.spec.ts

@@ -314,7 +314,7 @@ describe(`DiscordMessageCommandFeatureDuplicatedFlagsErrorService`, (): void =>
 
       const result = await service.getMessageResponse(flagsDuplicated);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-duplicated-flags-error.service.ts

@@ -33,7 +33,6 @@ export class DiscordMessageCommandFeatureDuplicatedFlagsErrorService extends Dis
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(flagsDuplicated)],
           },

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-empty-flags-error.service.spec.ts

@@ -255,7 +255,7 @@ describe(`DiscordMessageCommandFeatureEmptyFlagsErrorService`, (): void => {
 
       const result = await service.getMessageResponse(anyDiscordMessage, commands, featureName);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-empty-flags-error.service.ts

@@ -36,7 +36,6 @@ export class DiscordMessageCommandFeatureEmptyFlagsErrorService extends DiscordM
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(anyDiscordMessage, commands, featureName)],
           },

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-opposite-flags-error.service.spec.ts

@@ -314,7 +314,7 @@ describe(`DiscordMessageCommandFeatureOppositeFlagsErrorService`, (): void => {
 
       const result = await service.getMessageResponse(oppositeFlags);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-opposite-flags-error.service.ts

@@ -31,7 +31,6 @@ export class DiscordMessageCommandFeatureOppositeFlagsErrorService extends Disco
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(oppositeFlags)],
           },

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-wrong-flags-error.service.spec.ts

@@ -292,7 +292,7 @@ describe(`DiscordMessageCommandFeatureWrongFlagsErrorService`, (): void => {
 
       const result = await service.getMessageResponse(flagsErrors);
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 });

src/features/discord/messages/services/command/feature/services/flags/discord-message-command-feature-wrong-flags-error.service.ts

@@ -31,7 +31,6 @@ export class DiscordMessageCommandFeatureWrongFlagsErrorService extends DiscordM
       .getCliErrorMessageResponse()
       .then((cliErrorMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed(flagsErrors)],
           },

src/features/discord/messages/services/command/help/discord-message-command-help.service.spec.ts

@@ -384,7 +384,7 @@ describe(`DiscordMessageCommandHelpService`, (): void => {
 
         const result = await service.getMessageResponse();
 
-        expect(result.content).toBe(``);
+        expect(result.content).toBeUndefined();
       });
     });
 

src/features/discord/messages/services/command/help/discord-message-command-help.service.ts

@@ -40,7 +40,6 @@ export class DiscordMessageCommandHelpService extends AbstractService {
       .getMessageResponse()
       .then((helpDiscordMessageResponse: Readonly<IDiscordMessageResponse>): Promise<IDiscordMessageResponse> => {
         const message: IDiscordMessageResponse = {
-          content: ``,
           options: {
             embeds: [this._getMessageEmbed()],
           },

src/features/discord/messages/services/command/lunch/services/discord-message-command-lunch.service.spec.ts

@@ -256,7 +256,7 @@ describe(`DiscordMessageCommandLunchService`, (): void => {
 
       const result = await service.getMessageResponse();
 
-      expect(result.content).toBe(``);
+      expect(result.content).toBeUndefined();
     });
   });
 

src/features/discord/messages/services/command/lunch/services/discord-message-command-lunch.service.ts

@@ -40,7 +40,6 @@ export class DiscordMessageCommandLunchService extends AbstractService {
 
   public getMessageResponse(): Promise<IDiscordMessageResponse> {
     const message: IDiscordMessageResponse = {
-      content: ``,
       options: {
         embeds: [this._getMessageEmbed()],
       },