V4.5 #2
Merged
V4.5 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#468) Co-authored-by: Bill Willcox <billwcorp@gmail.com>
Using a submodule to download and build GTest is a great approach for most circumstances, but some may prefer to use the system-provided GTest if it is available. This change adds a fallback to using the system's GTest if the submodule is absent.
On some platforms (like RedHat ones), CMAKE_INSTALL_LIBDIR is set to `lib64` instead of `lib`. The CMake files should also be installed to `lib64`, but because CONF_CMAKE_INSTALL_DIR is set unconditionally to use `lib`, the proper path can't be configured. This change makes CONF_CMAKE_INSTALL_DIR use the configured CMAKE_INSTALL_LIBDIR value, which defaults to `lib`.
…tanini#484) (mfontanini#486) According to the C/C++ Standard, for shift operations, the behavior is undefined if the right operand is equal to the width of the promoted left operand. On a 64-bit Windows machine, this causes IP addresses 0.0.0.0 and 255.255.255.255 to have the same internal representation, leading to various issues when using a /0 prefix.
Due to changes in GCC13 need fix include.
`<algorithm>` is needed for std::fill (error in clang-16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.