Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonarqube-scan-action 404 fix #103

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Conversation

mbianchidev
Copy link
Contributor

Hi team, I updated your README.md to fix a 404 for sonarqube-scan-action in the GitHub marketplace!

Update README.md to fix 404 action
@henryju
Copy link
Member

henryju commented Feb 26, 2025

@antonioaversa are you aware of this? What is this name official-sonarqube-scan?

@mbianchidev
Copy link
Contributor Author

Hey @henryju thanks for triaging this!

My rationale is that the deprecation notice on the marketplace should point to the other marketplace item directly (possibly through a link)

The current name is the repository name for the action (that differs from the marketplace name) and it could be misleading when one looks for that name in the marketplace itself.

Hope this helps clarifying why I opened the PR 😄

mbianchidev and others added 3 commits February 27, 2025 12:25
Co-authored-by: Julien HENRY <julien.henry@sonarsource.com>
Co-authored-by: Julien HENRY <julien.henry@sonarsource.com>
@mbianchidev
Copy link
Contributor Author

@henryju done, thanks for reviewing!

Copy link
Member

@henryju henryju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henryju henryju merged commit ffc3010 into SonarSource:master Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants