SONARJAVA-6016 Migrate the Guava project in the ruling tests to Java 21#5459
Open
aurelien-coet-sonarsource wants to merge 1 commit intomasterfrom
Open
SONARJAVA-6016 Migrate the Guava project in the ruling tests to Java 21#5459aurelien-coet-sonarsource wants to merge 1 commit intomasterfrom
aurelien-coet-sonarsource wants to merge 1 commit intomasterfrom
Conversation
|
aurelien-coet-sonarsource
requested a review
from tomasz-tylenda-sonarsource
asya-vorobeva
requested changes
Feb 13, 2026
Contributor
asya-vorobeva
left a comment
asya-vorobeva
left a comment
There was a problem hiding this comment.
- Add in PR description reference to the related one SonarSource/ruling_java#9
- About changes in its/sources: I'm sure that we don't need to change everything here, cause it's a git submodule linked to ruling_java repo, should be updated automatically after merging the first PR.
Contributor
Author
|
Yes, once the PR in ruling_java will be merged, we'll just need to update the submodule to point to the latest commit on master instead of the one on my branch. |
Contributor
It means you can revert changes in its\sources. Let's do it after merge that PR(already approved) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Related PR in the ruling_java project.