Reduce nesting

SonarSource · Mar 21, 2024 · 7099130 · 7099130
1 parent 8ad9358
commit 7099130
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/SpecifyRouteAttribute.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/SpecifyRouteAttribute.cs
@@ -66,20 +66,22 @@ protected override void Initialize(SonarAnalysisContext context) =>
 
     private void ReportIssues(SonarSymbolReportingContext context, ISymbol symbol, ConcurrentStack<Location> secondaryLocations)
     {
-        if (!secondaryLocations.IsEmpty)
+        if (secondaryLocations.IsEmpty)
         {
-            foreach (var declaration in symbol.DeclaringSyntaxReferences.Select(x => x.GetSyntax()))
+            return;
+        }
+
+        foreach (var declaration in symbol.DeclaringSyntaxReferences.Select(x => x.GetSyntax()))
+        {
+            if (declaration.GetIdentifier() is { } identifier)
             {
-                if (declaration.GetIdentifier() is { } identifier)
-                {
-                    context.ReportIssue(CSharpGeneratedCodeRecognizer.Instance, Diagnostic.Create(Rule, identifier.GetLocation(), secondaryLocations));
+                context.ReportIssue(CSharpGeneratedCodeRecognizer.Instance, Diagnostic.Create(Rule, identifier.GetLocation(), secondaryLocations));
 
-                    // When a symbol was declared in multiple locations, we want to avoid reporting the same secondary locations multiple times.
-                    // The list is cleared only if the declaration is not in generated code. Otherwise, the secondary locations are not reported at all.
-                    if (!Language.GeneratedCodeRecognizer.IsGenerated(declaration.SyntaxTree))
-                    {
-                        secondaryLocations.Clear();
-                    }
+                // When a symbol was declared in multiple locations, we want to avoid reporting the same secondary locations multiple times.
+                // The list is cleared only if the declaration is not in generated code. Otherwise, the secondary locations are not reported at all.
+                if (!Language.GeneratedCodeRecognizer.IsGenerated(declaration.SyntaxTree))
+                {
+                    secondaryLocations.Clear();
                 }
             }
         }