Fix reporting on partial classes

SonarSource · Mar 21, 2024 · 234510c · 234510c
1 parent adfa035
commit 234510c
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/analyzers/src/SonarAnalyzer.CSharp/Rules/SpecifyRouteAttribute.cs b/analyzers/src/SonarAnalyzer.CSharp/Rules/SpecifyRouteAttribute.cs
@@ -75,6 +75,9 @@ private static void ReportIssues(SonarSymbolReportingContext context, ISymbol sy
                 if (declaration.GetIdentifier() is { } identifier)
                 {
                     context.ReportIssue(CSharpGeneratedCodeRecognizer.Instance, Diagnostic.Create(Rule, identifier.GetLocation(), secondaryLocations));
+
+                    // When a symbol was declared in multiple locations, we want to avoid reporting the same secondary locations multiple times.
+                    secondaryLocations.Clear();
                 }
             }
         }

diff --git a/analyzers/tests/SonarAnalyzer.Test/Rules/SpecifyRouteAttributeTest.cs b/analyzers/tests/SonarAnalyzer.Test/Rules/SpecifyRouteAttributeTest.cs
@@ -52,7 +52,6 @@ public partial class HomeController : Controller       // Noncompliant
                         {
                             [HttpGet("Test")]
                             public IActionResult Index() => View();            // Secondary
-                                                                               // Secondary @-1
                         }
                         """)
             .AddSnippet("""
@@ -64,6 +63,30 @@ public partial class HomeController : Controller       // Noncompliant
                         }
                         """)
             .Verify();
+
+    [TestMethod]
+    public void SpecifyRouteAttribute_PartialClasses_OneGenerated_CS() =>
+        builder
+            .AddSnippet("""
+                        using Microsoft.AspNetCore.Mvc;
+                        using Microsoft.AspNetCore.Mvc.Routing;
+
+                        public partial class HomeController : Controller       // Noncompliant
+                        {
+                            [HttpGet("Test")]
+                            public IActionResult Index() => View();            // Secondary
+                        }
+                        """)
+            .AddSnippet("""
+                        // <auto-generated/>
+                        using Microsoft.AspNetCore.Mvc;
+                        using Microsoft.AspNetCore.Mvc.Routing;
+
+                        public partial class HomeController : Controller
+                        {
+                        }
+                        """)
+            .Verify();
 }
 
 #endif