Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-668 Modify S7130: Add vbnet rspec #4499

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

pavel-mikula-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-georgiou-sonarsource mary-georgiou-sonarsource marked this pull request as draft November 14, 2024 10:20
@mary-georgiou-sonarsource
Copy link
Contributor

Converted to DRAFT so we don't merge before the rule is merged.

},
"tags": [
],
"defaultSeverity": "Major",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavel-mikula-sonarsource re-seeing this - is it really major?
Maybe medium?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severities are "Info","Minor","Major","Critical","Blocker". Major is maped to Medium,
https://docs.sonarsource.com/sonarqube/9.9/user-guide/issues/

It's closer to "unused parameter" and "why the hell is this here" than "this is just too long line and that makes it hard to read"

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review November 14, 2024 12:25
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit a0be31c into master Nov 14, 2024
13 of 14 checks passed
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the Pavel/S7130-vbnet branch November 14, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants