-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NET-668 Modify S7130: Add vbnet rspec #4499
Conversation
Quality Gate passed for 'rspec-tools'Issues Measures |
Quality Gate passed for 'rspec-frontend'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Converted to DRAFT so we don't merge before the rule is merged. |
}, | ||
"tags": [ | ||
], | ||
"defaultSeverity": "Major", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavel-mikula-sonarsource re-seeing this - is it really major?
Maybe medium?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Severities are "Info","Minor","Major","Critical","Blocker". Major is maped to Medium,
https://docs.sonarsource.com/sonarqube/9.9/user-guide/issues/
It's closer to "unused parameter" and "why the hell is this here" than "this is just too long line and that makes it hard to read"
Review
A dedicated reviewer checked the rule description successfully for: