Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify rule S2068: Description should not recommend customizing it with tokens #4496

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Modify rule S2068: Description should not recommend customizing it with tokens #4496

merged 1 commit into from
Nov 13, 2024

Conversation

jonas-wielage-sonarsource
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@jonas-wielage-sonarsource jonas-wielage-sonarsource changed the title Modify S2068: Description should not recommend customizing it with tokens Modify rule S2068: Description should not recommend customizing it with tokens Nov 13, 2024
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

mstachniuk
mstachniuk approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mstachniuk mstachniuk merged commit 8093bf5 into master Nov 13, 2024
10 of 12 checks passed
@mstachniuk mstachniuk deleted the jonas/modify-S2068 branch November 13, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstachniuk mstachniuk mstachniuk approved these changes

Assignees
No one assigned
Labels
php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonas-wielage-sonarsource @mstachniuk