Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7158: String.isEmpty() should be used to test for emptiness. #4493

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource changed the title Create rule S7158 Create rule S7158: String.isEmpty() should be used to test for emptiness. Nov 13, 2024
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource marked this pull request as ready for review November 13, 2024 10:58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Let's fix some Rspec formatting and add some docs

rules/S7158/java/rule.adoc Show resolved Hide resolved
rules/S7158/java/rule.adoc Outdated Show resolved Hide resolved
rules/S7158/java/rule.adoc Show resolved Hide resolved
Co-authored-by: leonardo-pilastri-sonarsource <115481625+leonardo-pilastri-sonarsource@users.noreply.github.com>
Co-authored-by: leonardo-pilastri-sonarsource <115481625+leonardo-pilastri-sonarsource@users.noreply.github.com>
Co-authored-by: leonardo-pilastri-sonarsource <115481625+leonardo-pilastri-sonarsource@users.noreply.github.com>
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource merged commit 41e6f81 into master Nov 14, 2024
11 of 12 checks passed
@leonardo-pilastri-sonarsource leonardo-pilastri-sonarsource deleted the rule/add-RSPEC-S7158 branch November 14, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants