-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create rule S6922 #3624
base: master
Are you sure you want to change the base?
Create rule S6922 #3624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small grammar mistake and a suggestion to link to some more documentation.
rules/S6922/python/metadata.json
Outdated
@@ -0,0 +1,24 @@ | |||
{ | |||
"title": "arguments of \"tf.divide\" should have same shape or be broadcastable to the same shape", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small grammar mistake. missing a the: arguments of \"tf.divide\" should have
the same shape
---- | ||
Here, each element of `x` is divided by the corresponding element of `y`. | ||
|
||
One limitation to be aware of when using `tf.divide` is that both `x` and `y` must be of compatible shapes. In other words, they must have the same shape or be broadcastable to the same shape. Otherwise it will lead to `InvalidArgumentError`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add a word on broadcasting or a link to the documentation for broadcasting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a link to numpy documentation explaining broadcastable matrices
Quality Gate passed for 'rspec-frontend'Issues Measures |
Quality Gate passed for 'rspec-tools'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: