Add support for 2.5GBASE-T and 5GBASE-T interface types #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Multigig" interfaces (supporting 2.5G or 5G max speeds) are BaseT only (the SFP+ interface standard always supports 10G as max), so we don't need to check if these ports are a fiber media type
|
Thank you for your contribution ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These max_speed of 2500Mbps and 5000Mbps are BaseT only as far as I can tell so I didn't bother to check the port type, but I can add that in if desired
There are 2.5GBase-SR SFP transceivers (not sure if these are part of any kind of standard) but that doesn't seem to be an option in netbox and SFP ports even when capable of 2.5G get reported as max_speed 1000Mbps as far as I can tell