Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the package version from 4.0.0 to 4.0.1, indicating a patch release. Additionally, it converts the UMD bundle test file to use ES modules with import maps, changing from testing locally-built UMD bundles to testing the published ESM package via the esm.sh CDN.
- Version bumped from 4.0.0 to 4.0.1 (patch release)
- Test file converted from UMD bundle testing to ESM module testing
- Test now uses esm.sh CDN to load published packages instead of local builds
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package.json | Version incremented to 4.0.1 for patch release |
| test/testBundles/test-umd.html | Converted from UMD bundle test to ESM module test using import maps and esm.sh CDN; however, the filename and heading still reference "UMD" which is inconsistent with the new implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -7,18 +7,25 @@ | |||
| <body> | |||
| <h1>Solid Logic UMD Bundle Browser Test</h1> | |||
There was a problem hiding this comment.
The heading still says "Solid Logic UMD Bundle Browser Test", but the test has been converted to use ES modules (ESM) with import maps instead of a UMD bundle. The heading should be updated to "Solid Logic ESM Module Browser Test" or similar to accurately reflect what is being tested.
| "rdflib": "https://esm.sh/rdflib", | ||
| "solid-logic": "https://esm.sh/solid-logic" |
There was a problem hiding this comment.
The import map points to https://esm.sh/solid-logic which will load the published version from npm. This means the test won't be testing the local development version of the code. If the intent is to test local changes before publishing, consider either: 1) pointing to a local build, 2) creating a separate test file for CDN validation, or 3) adding a comment explaining this tests the published version.
No description provided.