extrude_along_path() is broken - normals inverted #187

Activity

1. etjones

   added a commit that references this issue on Sep 30, 2021

   Fix for #187. `solid.utils.extrude_along_path()` was generating `poly…

   ...

   37417da
2. etjones commented on Sep 30, 2021

   

   etjones

   on Sep 30, 2021

   Contributor

   More actions

   Good catch on this. I was adding lots and lots of inverted facets to the polyhedron() calls, which I just now realized can be visualized with OpenSCAD's F12 'Thrown Together' view. Everything should look good now. You'd need to pull the latest master to see the fix, but it's there. I'm going to hold off on a release just now, because there's a much bigger release coming shortly and I'm not sure where this will end up in the mix.
3. etjones

   closed this as completedon Sep 30, 2021
4. Gigahawk commented on Nov 11, 2021

   

   Gigahawk

   on Nov 11, 2021

   Last edited by Gigahawk

   More actions

   As far as I can tell, this is still broken as of 37417da, running path_extrude_example.py still breaks when trying to render in OpenSCAD.

   Reverting to 1.0.5 seems to work fine.
5. etjones commented on Nov 11, 2021

   

   etjones

   on Nov 11, 2021

   Contributor

   More actions

   What kind of failure do you run into? Running the code at 37417da it took me almost 14 minutes to render with CGAL, but everything looks like it's working correctly. What does your breakage look like?
6. etjones

   reopened this on Nov 11, 2021
7. Gigahawk commented on Nov 12, 2021

   

   Gigahawk

   on Nov 12, 2021

   More actions

   Ok weird, I tried to recreate this in a clean environment and it seems to work fine, maybe pip didn't replace the regular 1.1.1 release when i tried to install from git.

   My bad, feel free to close this again.
8. etjones commented on Nov 12, 2021

   

   etjones

   on Nov 12, 2021

   Contributor

   More actions

   All good- “no bug here” is the best outcome! Thanks for reporting.
9. etjones

   closed this as completedon Nov 12, 2021