Remove Result<(), E> from the API
#16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolarLiner
added
Upstream
GitGhillie
reviewed
May 7, 2024
GitGhillie
approved these changes
May 8, 2024
|
Yeah I wanted to add the flake in another PR but ended up needing it for my laptop, so it's here. I'll merge it with it, but I also don't know the NixOS stuff, so I'm sure it's not optimal 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
Description
Upgrading Kira to 0.9 meant that most of the fallible methods disappeared, which in turn automatically solved the issue.
Breaking changes
AudioFileHandlemethods no longer returnResults, error handling is therefore not required anymore.