JS Sample update on Guaranteed Publisher/Subscriber and Queue Producer/Consumer #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed samples) - Modified QueueProducer & QueueConsumer to work with Topic subscriptions - Moved QueueProducer & Consumer to features - Added Guaranteed Publisher & Subscriber aligned with convention based topic solace/samples/js/pers/pub/* Updated the HTML & CSS with a additional instruction (pre-requsiite) and a clear button to unclutter the textarea - Next iteration, we shall apply this on the rest of the samples
- Broker -> message router vpn - Topic name solace/samples/js/pers/pub/> -> solace/samples/js/pers/>
| logTextArea.scrollTop = logTextArea.scrollHeight; | ||
| }; | ||
|
|
||
| publisher.log('\n*** publisher to topic "' + publisher.topicName + '/*" is ready to connect ***'); |
There was a problem hiding this comment.
replace /* with {correlation_id} in the log
| @@ -142,17 +143,20 @@ <h3>Queue Consumer</h3> | |||
| </div> | |||
|
|
|||
| </fieldset> | |||
| <div class="box"> | |||
| NOTE: Before you proceed, please ensure that the required queue is created on the message router vpn. | |||
There was a problem hiding this comment.
can we replace message router vpn with Solace PubSub+ Event Broker throughout the samples please.
TamimiGitHub
approved these changes
Nov 13, 2022
- Renamed references "Solace Message Router." -> "Solace PubSub+ Event Broker." - Added "optional" comment/note on the QueueProducer & GuraranteedPublisher around the use of CorrelationKey
…t Broker." - Added "optional" comment/note on the QueueProducer & GuraranteedPublisher around the use of CorrelationKey
gvensan
added a commit
to gvensan/solace-samples-javascript
that referenced
this pull request
Jan 2, 2023
Merge pull request SolaceSamples#56 from gvensan/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to bring JS samples on par with JCSMP samples
Changes:
Updated the HTML & CSS with additional instruction (pre-requisite) and a clear button to unclutter the textarea