Skip to content

Bug SOL-79800: Emirates: Issue with SecureSession sample for Javascri… #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

Bug SOL-79800: Emirates: Issue with SecureSession sample for Javascri… #55

merged 1 commit into from
Oct 12, 2022

Conversation

gszol
Copy link
Contributor

@gszol gszol commented Oct 12, 2022

Reinstating the iframe in the TLS sample.

Bug SOL-79800: Emirates: Issue with SecureSession sample for Javascri…
c022b51 
…pt API when establishing one-way SSL connection

Reinstating the iframe in the TLS sample.
@TamimiGitHub
Copy link
Contributor

Do we still need to add the crossdomain.xml requests to the other samples? I recall running the other samples with no issues. Or is this only an issue with one-way SSL connections?

@gszol
Copy link
Contributor Author

gszol commented Oct 12, 2022

Do we still need to add the crossdomain.xml requests to the other samples? I recall running the other samples with no issues. Or is this only an issue with one-way SSL connections?

This is an issue when the broker URL calls for TLS (wss:// or https://).
It is only the "SecureSession" sample that enforces that, all other samples allow plain-text broker communication, which works as-is and I don't mean to rock the boat more than necessary.

TamimiGitHub
TamimiGitHub approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@TamimiGitHub TamimiGitHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. LGTM! You can merge 👍

@gszol
Copy link
Contributor Author

gszol commented Oct 12, 2022

Makes sense. LGTM! You can merge 👍

"Only those with write access to this repository can merge pull requests."

Looks like I'll have to ask you to do it for me please.

@TamimiGitHub TamimiGitHub merged commit f3a5e23 into SolaceSamples:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TamimiGitHub TamimiGitHub TamimiGitHub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gszol @TamimiGitHub