-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All external dependency #351
Comments
I do not understand this issue very well, sorry. Can you provide an
example? Thanks!
El mar., 21 jun. 2022 7:06 p. m., Clark Wang ***@***.***>
escribió:
… I have reviewed most of the results from the inspect4py, and as far as I
can tell, all *dependency* modules have the same type, which is external.
However, from an user perspective, I think if this function or class is
inside of this project, it should be *internal*.
—
Reply to this email directly, view it on GitHub
<#351>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTIGW3QT2CXYJVPWMRMETVQIAEFANCNFSM5ZNHBKWA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
So the problem is that all depencies of a file are marked as |
Could you give an example,with a repo, or something ? |
Dear Rosa,
Of course, this repo is one of the many tests that I have viewed, and the attached file is the inspect4py result. The dependency part is all external due to the refered line is m+i+'.py', I believe to i , is a function instead of the files.
Best,
Clark
At 2022-07-04 18:17:33, "Rosa Filgueira" ***@***.***> wrote:
Could you give an example,with a repo, or something ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@OEG-Clark, |
Dear All,
This is the result of the first dependencies block of 0101 result. And you could see the pipetools should be internal but it is exteranl.
在 2022-07-04 18:30:41,"Daniel Garijo" ***@***.***> 写道:
@OEG-Clark,
can you please paste the concrete repository where this happens? We have tested one locally, but we saw the internal dependencies showing nicely
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
you mean the 0101 pipetools? |
Hi @OEG-Clark , Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails. If you can actually copy the repo in the body of the message ( and maybe also, include the command that you are using), that will be fantastic. For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo: ''' If I try this test, it detects well the type of dependencies. But it is true, that is just a mini-test! If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message. Thanks! |
Oh, of course, I will add details in the issue page under issue 38.
At 2022-07-04 19:25:44, "Rosa Filgueira" ***@***.***> wrote:
Hi @OEG-Clark ,
Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails.
If you can actually copy paste the
For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo:
'''
inspect4py -i test/test_files/test_inheritance/test_import.py -o output_test -si -html
'''
If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Dear All,
I have added more detail here.
Best
Clark
At 2022-07-04 19:25:44, "Rosa Filgueira" ***@***.***> wrote:
Hi @OEG-Clark ,
Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails.
If you can actually copy paste the
For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo:
'''
inspect4py -i test/test_files/test_inheritance/test_import.py -o output_test -si -html
'''
If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I have reviewed most of the results from the inspect4py, and as far as I can tell, all dependency modules have the same type, which is external. However, from an user perspective, I think if this function or class is inside of this project, it should be internal.
The text was updated successfully, but these errors were encountered: