Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All external dependency #351

Open
OEG-Clark opened this issue Jun 21, 2022 · 10 comments
Open

All external dependency #351

OEG-Clark opened this issue Jun 21, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@OEG-Clark
Copy link
Contributor

I have reviewed most of the results from the inspect4py, and as far as I can tell, all dependency modules have the same type, which is external. However, from an user perspective, I think if this function or class is inside of this project, it should be internal.

@dgarijo
Copy link
Collaborator

dgarijo commented Jun 22, 2022 via email

@dgarijo
Copy link
Collaborator

dgarijo commented Jun 23, 2022

So the problem is that all depencies of a file are marked as external. We find no internal dependencies, even those functions that are defined within a package/library.

@dgarijo dgarijo added the bug Something isn't working label Jun 23, 2022
@rosafilgueira
Copy link
Collaborator

Could you give an example,with a repo, or something ?

@OEG-Clark
Copy link
Contributor Author

OEG-Clark commented Jul 4, 2022 via email

@dgarijo
Copy link
Collaborator

dgarijo commented Jul 4, 2022

@OEG-Clark,
can you please paste the concrete repository where this happens? We have tested one locally, but we saw the internal dependencies showing nicely

@OEG-Clark
Copy link
Contributor Author

OEG-Clark commented Jul 4, 2022 via email

@dgarijo
Copy link
Collaborator

dgarijo commented Jul 4, 2022

you mean the 0101 pipetools?

@rosafilgueira
Copy link
Collaborator

rosafilgueira commented Jul 4, 2022

Hi @OEG-Clark ,

Sorry, but I can not see the attached "file". Since, I am using the Github issue interface - I dont receive your messages as emails.

If you can actually copy the repo in the body of the message ( and maybe also, include the command that you are using), that will be fantastic.

For example, I have tested myself the "import dependencies" types , using a test file that we have in the repo:

'''
inspect4py -i test/test_files/test_inheritance/test_import.py -o output_test -si -html
'''

If I try this test, it detects well the type of dependencies. But it is true, that is just a mini-test!

If you can tell us (to have it document it) an example with a repo that gives you an error, that will be great. But write it in the body of the message.

Thanks!

@OEG-Clark
Copy link
Contributor Author

OEG-Clark commented Jul 4, 2022 via email

@OEG-Clark
Copy link
Contributor Author

OEG-Clark commented Jul 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants