Skip to content

October Release Fixes #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2023
Merged

October Release Fixes #217

merged 4 commits into from
Oct 18, 2023

Conversation

jwj7297
Copy link
Contributor

@jwj7297 jwj7297 commented Oct 16, 2023

  • Removed scrollbar on modal when no overflow

  • Can no longer convert from CDX -> CDX
    Note: (Other options such as SPDX -> SPDX remain in case you want to change schema), in the future could stop changing to the same schema however the backend doesn't currently return the schema of an sbom

  • Swapped schema and format labels as technically they were backwards on the modal
    Note; The backend currently has format and schema backwards so the client has to reverse them before sending the request... this should be fixed in the future but has no effect on the end user.

  • Fixed new convert files not appending to upload list correct

  • Fixed VEX Network call to send ID and not the sbom info object

Copy link
Member

@dlg1206 dlg1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in meeting

@dlg1206 dlg1206 merged commit e73164e into dev Oct 18, 2023
@dlg1206 dlg1206 deleted the dev-octReleaseFixes branch October 18, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll bar appears in modals on Window OS Convert: Dropdown to select format in modal allows converting an SBOM to the same type
2 participants