Skip to content

Refactor filestructure to remove 'frontend/' folder #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

Hooobot
Copy link
Contributor

@Hooobot Hooobot commented Sep 18, 2023

Allows SVIP able to run quickstart without changing directories

Changed PR to merge into dev instead of main.

Additional tests included launching the application as instructed
npm ci
npm start
... and being able to see the SVIP frontend UI

@Hooobot Hooobot requested review from dlg1206 and jwj7297 September 18, 2023 14:51
Copy link
Member

@dlg1206 dlg1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Restore readme.md
  • move changelog.md into a doc directory
    Quick start details in the original readme can be updated, but any additional details about troubleshooting / dev deployment in a doc/readme.md file

@Hooobot Hooobot closed this Sep 18, 2023
@Hooobot Hooobot reopened this Sep 18, 2023
@Hooobot Hooobot requested a review from dlg1206 September 18, 2023 22:52
Copy link
Member

@dlg1206 dlg1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hooobot Hooobot merged commit 8979b2a into dev Sep 18, 2023
@Hooobot Hooobot deleted the 168-remove-frontend-folder-dev branch September 18, 2023 23:52
dlg1206 pushed a commit that referenced this pull request Oct 1, 2023
* Refactor filestructure to remove 'frontend/' folder

* Restore 'readme.md' & added doc directory for changelog and README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants