-
Notifications
You must be signed in to change notification settings - Fork 0
[Feature]Data Gateway - LicenseGPT #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding API endpoint to allow communication with AI Agent about license reports
Fixed the same typo across entire spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new chat-based AI endpoint for querying license report data and updates related versioning and documentation.
- Bumped package and OpenAPI spec version to 2.1.3
- Added
Chat.MessageRecordschema and/Api/Chat/LicenseGptendpoint - Fixed typos (“form” → “from”) and added a new
Chattag
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dataGateway/TypeScript/package.json | Bumped SDK package version from 2.1.2 to 2.1.3 |
| specs/Data-Gateway.json | Added chat schema & endpoint, updated spec version, fixed typos |
Files not reviewed (1)
- src/dataGateway/TypeScript/package-lock.json: Language not supported
Comments suppressed due to low confidence (3)
specs/Data-Gateway.json:206
- Property name 'tool_calls' is snake_case and inconsistent with the camelCase naming used elsewhere (e.g., 'messageList', 'responseText'). Consider renaming to 'toolCalls'.
"tool_calls": {
specs/Data-Gateway.json:237
- Property name 'tool_call_id' is snake_case and inconsistent with the camelCase naming used elsewhere. Consider renaming to 'toolCallId' to follow naming conventions.
"tool_call_id": {
specs/Data-Gateway.json:1624
- Example uses single quotes inside the JSON string for 'content', which is not valid JSON. Consider using double quotes or escaping them properly to avoid confusion.
"content": "{'825a9d7e-0b62-4392-b8ef-ab6951a46ebd':'2025-07-03T18:39:50.828Z','744c0878-3a82-48a7-b239-a1d4b9298a69':'2025-07-07T21:01:20.995Z'}",
Making sure the example string is valid json stringified value
Enhancing example data to closer represent the real details of the request
Ensure that the Data Gateway API Spec version matches the published version of Data Gateway.
Regenerate Lock
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Regenerate lock
elliot-huffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a conversational AI endpoint for license reports and updates package dependencies.
- Bumps Azure auth, Node types, and
typiaversions in Shield and Data Gateway packages - Adds
Chat.OpenAIChatMessageschema and the/Api/Chat/LicenseGptendpoint to the API spec - Corrects minor typos in endpoint descriptions and bumps the spec version
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/shield/TypeScript/package.json | Updated devDependency versions for core-auth, types-node, typia |
| src/dataGateway/TypeScript/package.json | Bumped package version to 2.2.0 and updated devDependency versions |
| specs/Data-Gateway.json | Added Chat schema, new Chat endpoint, fixed typos, bumped spec version to 2.1.3 |
Files not reviewed (2)
- src/dataGateway/TypeScript/package-lock.json: Language not supported
- src/shield/TypeScript/package-lock.json: Language not supported
Comments suppressed due to low confidence (4)
specs/Data-Gateway.json:1009
- The OpenAPI spec version (2.1.3) doesn’t align with the Data Gateway package version (2.2.0); consider bumping the spec version to 2.2.0 for consistency.
"version": "2.1.3"
specs/Data-Gateway.json:206
- [nitpick] The property
tool_calls(andtool_call_id) uses snake_case while other schema properties use camelCase; consider renaming totoolCallsandtoolCallIdto match the rest of the spec.
"tool_calls": {
specs/Data-Gateway.json:1589
- The new Chat endpoint currently defines only 200 and 400 responses; consider adding standard HTTP error responses (e.g., 401, 403, 500) via
#/components/responsesto cover authentication and server failures.
"responses": {
specs/Data-Gateway.json:1572
- Consider adding integration or unit tests for the new
/Api/Chat/LicenseGptendpoint and theChat.OpenAIChatMessageschema to validate message parsing and tool call handling.
"post": {
Adding API endpoint to allow communication with AI Agent about license reports