Progress Bar addition to DataGateway - Feature Parity #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the progress bar to the DG
There was a problem hiding this comment.
Pull Request Overview
This PR adds a progress bar component specification to the Data Gateway JSON schema to achieve feature parity between SHIELD and Data Gateway UIs.
- Introduces a new
Core.ProgressBarschema definition with support for nested progress bars and both determinate/indeterminate progress states - Defines comprehensive properties for progress tracking including current step, total steps, display text, and unique identification
| "type": "number" | ||
| }, | ||
| "totalStepCount": { | ||
| "description": "Number of steps before the progress bar is completely filed.", |
There was a problem hiding this comment.
There is a spelling error in the description. 'filed' should be 'filled'.
Suggested change
| "description": "Number of steps before the progress bar is completely filed.", | |
| "description": "Number of steps before the progress bar is completely filled.", |
| }, | ||
| "type": "object", | ||
| "required": [ | ||
| "childBar", |
There was a problem hiding this comment.
Making 'childBar' a required field may be problematic since many progress bars won't have child bars. Consider making this optional or providing a default empty array.
Suggested change
| "childBar", |
Contributor
|
DG won't have progress bars for the foreseeable future. For now, we will not need this added. If this changes, we will need to do what you did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Progress bar to the DG spec for feature parity between the SHIELD and DG UI's.