-
Notifications
You must be signed in to change notification settings - Fork 0
[Feature] SHIELD - Deploy v3 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added routes for compare/restore/remove operations on the deployed resources Included routes for override handling during the evaluation process Updated existing routes to reflect current set of possible response codes and changed payloads or returned structures Removing obsolete /version route
Updating Get call to include another property being returned Adding Patch call for the tag handling and extra resource provisioning
… to list records Compare and Compare/Invoke endpoints now return data as arrays instead of objects with dynamic property names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Shield API routes to reflect the new Deploy V3 process architecture, expanding the deployment functionality from basic infrastructure deployment to a comprehensive resource management system.
- Updates existing /Api/Deploy endpoint with new status codes and enhanced request/response structures
- Adds new endpoints for architecture management, resource evaluation, restoration, removal, and skip rule handling
- Removes obsolete /Api/Deploy/Version endpoint and updates several endpoint summaries for consistency
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/shield/TypeScript/package.json | Version bump from 3.0.4 to 3.0.5 |
| specs/SHIELD.json | Major API specification update adding new Deploy V3 schemas, endpoints, and restructuring existing deployment routes |
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
Thanks copilot
Adding new endpoint to handle requests for list of configuration items Adjusting path on the request for the list of architectures
Properties describing used plugins are not needed
elliot-huffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update to OpenAPI 3.1 as seen on the main branch. Thanks!
Enhanced information presentation with elements expected in OpenApi spec v3.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- src/shield/TypeScript/package-lock.json: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
elliot-huffman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixes, looks good!
Deploy v3 update