Adding query search params #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating 2 api endpoints to reflect support for query search parameters dateStart and dateEnd when retrieving License report data
There was a problem hiding this comment.
Pull Request Overview
This PR updates the API endpoints to support query search parameters for filtering License report data by date. Key changes include:
- Bumping the package version from 2.1.0 to 2.1.1.
- Adding query parameters (dateStart and dateEnd) to the OpenAPI specification.
- Updating endpoint descriptions to mention the new filtering options.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dataGateway/TypeScript/package.json | Bumps version to reflect updated API endpoints. |
| specs/Data-Gateway.json | Adds query parameters for date filtering and updates endpoint descriptions accordingly. |
Comments suppressed due to low confidence (1)
specs/Data-Gateway.json:1167
- The operationId uses ':' notation for tenantId, which is inconsistent with the URL's '{tenantId}' format. Consider using a consistent parameter notation.
"operationId": "/Api/LicenseReport/Correlation/Tenant/:tenantId/Get",
Correcting typo
Updating version in lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating 2 api endpoints to reflect support for query search parameters dateStart and dateEnd when retrieving License report data