Repository navigation
Make whole-feedback completion explicit after point resolution - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the final point is resolved, the feedback remains open and its point summary does not explain how to finish the whole request. Show the remaining feedback status beside All points resolved and offer an explicit Resolve feedback action to authorized members. Point resolution continues to preserve the independent thread decision; removed-only and partially complete reviews do not prompt closure.
The action uses the existing revision-checked status operation. Preserve structured API error codes so conflict recovery loads fresh feedback before retrying instead of searching the error message for a code. Refresh the affected dependency resolutions within their existing ranges because newly published advisories fail the required audit gate.
Validation: formatting, harness/docs checks, typecheck, plugin build and the complete local test suite passed (521 tests passed, 41 conditional skips, zero failures). App/site/extension builds, disposable sandbox smoke, release checks and npm audit passed with zero vulnerabilities. All nine evidence browser tests passed, including hidden open points and stale revision/reload/retry. Synthetic desktop/mobile and keyboard completion were inspected, followed by keyboard completion against the built app and actual isolated server. Required CI remains the merge gate.