1724 replace common business service exceptions with serviceresult #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic for handling it
…OpenJudgeSystem into 1724-replace-common-business-service-exceptions-with-serviceresult
…llerResultExtensions`. Excluded `NotFound` and `AccessDenied` cases from activity failure marking.
… ValidationResult. Enhanced `SubmitSubmissionService` with `ServiceResult` pattern and adjusted controller methods accordingly. Updated dependencies in `yarn.lock`.
…actions. Enhanced error handling with detailed contexts and updated `ControllerResultExtensions` to align with refined error codes.
**Summary of changes made**: 1. Replaced `forwardToAdmin` with `fallbackHtmlRoutes` to better handle route fallback scenarios. 2. Ensured non-API HTML requests fallback to `index.html`. 3. Retained `/administration` routing fallback to `admin.html`.
…/OpenJudgeSystem into 1724-replace-common-business-service-exceptions-with-serviceresult
…sult` pattern, removing exception handling. Updated related business logic and models for improved error handling and response consistency.
…OpenJudgeSystem into 1724-replace-common-business-service-exceptions-with-serviceresult
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1724
Summary of the changes made: